Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.11.0 #4974

Merged
merged 14 commits into from
Aug 3, 2023
Merged

Conversation

atmaxinger
Copy link
Contributor

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

- <<TODO>>
- <<TODO>>
- <<TODO>>
- Implemented the first revision of the Xfconf binding. _(Richard Stöckl @Eiskasten)_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eiskasten is this really new in this release? Or was this just not removed from a previous version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be correct. The xfconf binding was not included in v0.10.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the 3rd highlight then. Was someone already able to fully run everything in the tutorial of the xfconf binding? We probably should merge this for the release, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #4948 it works for me now in the debian image.

@atmaxinger
Copy link
Contributor Author

jenkins build libelektra please

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for working on the release!

- infos/status = configurable readonly preview unfinished nodoc
- infos/status = configurable readonly preview unfinished
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember that the documentation was improved there? I don't think we can rely on the heuristics of the update tool, please verify manually (or keep as-is).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this plugin actually seems to have extensive documentation at a first glance.

- New Changetracking API
- New spec plugin
- <<HIGHLIGHT>>
- ODBC Backend _(Florian Lindner @flo91)_

### Session Recording
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe do a small https://asciinema.org with how recording works? (we already did in earlier releases)

@atmaxinger
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger atmaxinger force-pushed the release-v0.11 branch 2 times, most recently from e005e5f to 78dba9a Compare July 11, 2023 14:13
@markus2330
Copy link
Contributor

please also increment year in LICENSE.md

@atmaxinger atmaxinger force-pushed the release-v0.11 branch 3 times, most recently from cc314ef to b79754d Compare July 18, 2023 18:05
@atmaxinger
Copy link
Contributor Author

jenkins build libelektra please

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, a few minor notes. You can do the release from my point of view 🚀

doc/news/_preparation_next_release.md Outdated Show resolved Hide resolved
src/plugins/template/README.md Outdated Show resolved Hide resolved
@@ -5,7 +5,7 @@
- infos/provides = storage/xml
- infos/recommends =
- infos/placements = getstorage setstorage
- infos/status = maintained libc configurable experimental unfinished concept limited memleak
- infos/status = maintained unittest libc configurable memleak experimental limited unfinished concept
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add such a disclaimer in doc/tutorials/xfconf.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly?

@markus2330 markus2330 requested a review from flo91 July 29, 2023 14:53
@atmaxinger
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger atmaxinger merged commit a660c74 into ElektraInitiative:master Aug 3, 2023
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants