New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Internal Cache #4964
base: master
Are you sure you want to change the base?
Implement Internal Cache #4964
Conversation
ksAppend (keysForSpec, dataKs); | ||
ksAppend (keysForSpec, fromInternalCache); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ksAppend (keysForSpec, dataKs); | |
ksAppend (keysForSpec, fromInternalCache); | |
ksAppend (keysForSpec, fromInternalCache); | |
ksAppend (keysForSpec, dataKs); |
Isn't this the wrong way around? In Step 18, fromInternalCache
is appended first
@@ -2055,6 +2084,7 @@ int kdbGet (KDB * handle, KeySet * ks, Key * parentKey) | |||
|
|||
ksDel (backends); | |||
ksDel (allBackends); | |||
if (fromInternalCache) ksDel (fromInternalCache); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (fromInternalCache) ksDel (fromInternalCache); | |
ksDel (fromInternalCache); |
ksDel (NULL)
is a no-op
below = ksBelow (handle->allKeys, backendKey); | ||
ksDel (ksCut (below, initialParent)); | ||
|
||
KeySet * bBackend = ksBelow (ks, backendKey); | ||
KeySet * bParent = ksBelow (bBackend, initialParent); | ||
ksAppend (below, bParent); | ||
|
||
ksDel (bParent); | ||
ksDel (bBackend); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be easier with ksFindHierarchy
and a loop of ksAppendKey
and performance-wise it makes no difference since ksAppend
is also a loop of ksAppendKey
right now (but you avoid allocating all these temporary KeySet
s).
Basics
(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels