-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kdb rewrite cpp spec #4949
Kdb rewrite cpp spec #4949
Conversation
e5fdf64
to
606508b
Compare
53f9bb0
to
b51edcd
Compare
606508b
to
2b8acf4
Compare
b51edcd
to
026b455
Compare
2b8acf4
to
29541dd
Compare
4138cfa
to
1aae751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. A clean simple solution for including the C++ code.
For the docs: We know prefer one sentence per line for new/updated docs (see here). I know many old docs are not written like this, so it can be easy to ignore this and follow the existing style in a file. But the new style really makes diffs easier to read, especially for small changes.
Otherwise, mostly questions and small suggestions. Nothing that really needs to change for a merge IMO.
One small but really nice addition would also be, if you added a KDB_WITHOUT_CPP
CMake variable. Which would exclude all C++ files from kdb
together with something like this in the main.c
:
#ifdef KDB_WITHOUT_CPP
cppCommand cppSubcommands[] = {};
#else
cppCommand cppSubcommands[] = {
// ... actual commands ...
};
#endif
Alternatively, KDB_WITHOUT_CPP
could include a dummy .c
which defines cpp_main
as a function that just prints "C++ not included". Then it would actually be possible to build kdb
without C++ (I think).
026b455
to
813f9c7
Compare
1aae751
to
30de929
Compare
30de929
to
b1a047d
Compare
813f9c7
to
c00b8cb
Compare
b1a047d
to
4bb4c09
Compare
Thanks for the feedback! |
c00b8cb
to
ef566b6
Compare
4bb4c09
to
339340a
Compare
jenkins build libelektra please |
1 similar comment
jenkins build libelektra please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
ef566b6
to
cdd5328
Compare
339340a
to
4785d62
Compare
Basics
Adds spec for cpp commands, so help/error messages are now generated by
opts
for bothC
andC++
commands. Nothing else really happens in this PR, except thatcmerge
->merge
.(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels