Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3742] Cascading writes #4908

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[#3742] Cascading writes #4908

wants to merge 4 commits into from

Conversation

hannes99
Copy link
Contributor

@hannes99 hannes99 commented Apr 21, 2023 •
edited

Disable cascading writes(fixes #3742), add new tests and update existing tests and docs. This also fixes #4028

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@hannes99 hannes99 requested review from flo91 and tmakar April 21, 2023 17:50
@hannes99 hannes99 changed the title [#3742]Cascading writes [#3742] Cascading writes Apr 21, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 21, 2023
View reviewed changes
src/tools/kdb/export.cpp Fixed Show fixed Hide fixed
atmaxinger
atmaxinger reviewed Apr 21, 2023
View reviewed changes
src/tools/kdb/mv.cpp Outdated Show resolved Hide resolved
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

tmakar
tmakar approved these changes Apr 22, 2023
View reviewed changes
src/tools/kdb/export.cpp Outdated Show resolved Hide resolved
src/tools/kdb/rm.cpp Show resolved Hide resolved
@tmakar
Copy link
Contributor

tmakar commented Apr 22, 2023 

After that use the command:

	cat man.patch | patch -p1

to apply the changes.

@hannes99 Regarding the man pages patch. Just copy the diff into a man.patch.

@tmakar
Copy link
Contributor

tmakar commented Apr 22, 2023

jenkins build libelektra please

@hannes99 hannes99 removed the request for review from flo91 April 22, 2023 14:38
@hannes99 hannes99 force-pushed the cascading-writes branch 3 times, most recently from 1cd9be9 to 82fb1f6 Compare April 23, 2023 04:02
atmaxinger
atmaxinger reviewed Apr 23, 2023
View reviewed changes
doc/help/kdb-find.md Outdated Show resolved Hide resolved
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

2 similar comments
@atmaxinger
Copy link
Contributor

jenkins build libelektra please

@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger atmaxinger mentioned this pull request Apr 28, 2023
Open
31 tasks
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

2 similar comments
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@hannes99
Copy link
Contributor Author

jenkins build libelektra please

1 similar comment
@hannes99
Copy link
Contributor Author

jenkins build libelektra please

@atmaxinger
Copy link
Contributor

You can stop doing this, this is a general error on our build server. It needs to be fixed first.

@tmakar
Copy link
Contributor

tmakar commented May 3, 2023

@hannes99 Please rebase!

@hannes99
Copy link
Contributor Author

hannes99 commented May 6, 2023

jenkins build libelektra please

markus2330
markus2330 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannes99 pls rebase

@hannes99
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmakar tmakar tmakar approved these changes

@markus2330 markus2330 markus2330 approved these changes

@atmaxinger atmaxinger Awaiting requested review from atmaxinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kdb set uses default: on cascading writes kdb disable cascading writes
4 participants
@hannes99 @tmakar @atmaxinger @markus2330