New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Mount tooling in C #4864
Draft
flo91
wants to merge
47
commits into
ElektraInitiative:kdb_cli_rewrite
Choose a base branch
from
flo91:mount_tooling_c
base: kdb_cli_rewrite
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Mount tooling in C #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add command.h containing helpful macros and a struct def that is needed later
... to command.c for resolving bookmarks in keynames.
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
... and remove cpp implementation
.. and remove cpp implementation
... and a GET_BASIC_OPTIONS macro for reading all basic basic options at the start of a command
... and (partial) fix ElektraInitiative#3742, fix ElektraInitiative#4028, fix ElektraInitiative#1164
... and (partial) fix ElektraInitiative#3742
.. and fix ElektraInitiative#3648
... and fix ElektraInitiative#3742
switch from the deprecated internal to external iteration
and check for failed kdbGet()
include header to some c-files for commands to fix linker errors
early stage, lots of open TODOs, work in progress
work in progress, not compiling
and some refactoring
hannes99
force-pushed
the
kdb_cli_rewrite
branch
30 times, most recently
from
May 19, 2023 05:31
4068491
to
57862d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basics
This PR has basically the same content as the PR #4851, but it should be merged into
kdb_cli_rewrite
instead ofmount_cli_integration
.I created a new branch based on the current version of the
kdb_cli_rewrite
branch.The upstream branch
mount_cli_integration
contains the commits ofkdb_cli_rewrite
and on top of that the commits for the mount-tooling, which are also included in this PR.The problem is, that the commits in
mount_cli_integration
that originally came fromkdb_cli_rewrite
have a different SHA1 than the commits inkdb_cli_rewrite
.This PR contains the original commits from
kdb_cli_rewrite
with the correct SHA1-hashes.tl;dr: The branch
mount_cli_integration
on upstream can be deleted.Then we have only
kdb_cli_rewrite
on upstream and my PRs are based on that branch and target it.(added as entry in
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add them to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels