New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Decision] Commit function #4777
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the existing decision to match the new template. Specifically, please switch to using subsections in the "Considered Alternatives". That makes is a lot easier to read, write and talk about options.
IMO the decision can be moved to at least "In Discussion", but probably even "In Progress".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! May you give some examples for function which potentially get called multiple times? I.e. if they are contract functions, plugin internal functions, etc.
fa64ee7
to
5254e2b
Compare
to the decision `doc/decisions/0_drafts/commit_function.md`
5254e2b
to
9c42f9f
Compare
- move to state "solutions clear" - add new assumption - extend the description of some possible solutions
- describe the current situation in more detail - mention the affected plugin functions
This PR is for working on the decision about the commit function (communicating the current phase to plugins).
It should at least reach the state "solutions clear" before closing this PR.
Basics
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels