Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Make Lua and Python optional in packaging script #4721

Closed

Conversation

0x6178656c
Copy link
Contributor

I rewrote parts of scripts/packaging/package.sh to make the Python and LUA dependencies optional.

I tried to keep things POSIX compatible.

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and no further pushes are planned by you.

@markus2330
Copy link
Contributor

LGTM!

@0x6178656c How do you use the packaging script and which error occurred so that you got this idea?

@mpranj can you check if this works for the release pipeline (still builds python+lua bindings)?

@0x6178656c
Copy link
Contributor Author

@0x6178656c How do you use the packaging script and which error occurred so that you got this idea?

To be honest, I am not entirely sure why this script is needed.

In the past I was able to package Elektra on Debian only using this script (cf. #4543). Since I wanted to package a minimal Elektra installation I did not want to have Lua or Python installed.

I think that it should be possible to configure the packaging only using CMake (and cpack). Is there a good reason for having this extra script?

@flo91
Copy link
Collaborator

flo91 commented Dec 19, 2022

jenkins build libelektra please

@0x6178656c 0x6178656c closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants