Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLOSS H2] Upgrade Jenkins node to Debian bullseye #4620

Merged

Conversation

0x6178656c
Copy link
Contributor

Since the CMake version is now incompatible with the one from the Debian stretch repository, I upgraded the Dockerfile to use Debian bullseye.

The only change in packages was:

  • openjdk-8-jdk-headless to openjdk-11-jdk-headless

I successfully ran

run-make-env

in the container.

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and no further pushes are planned by you.

* Change Debian release from `stretch` to `bullseye`
* Change package `openjdk-8-jdk-headless` to `openjdk-11-jdk-headless`
@markus2330
Copy link
Contributor

Thank you for the PR, great job! Can you please also update scripts/docker/jenkinsnode/README.md

The README.md needs some overhaul, it is not confirming to the Documentation Guidelines.

@lukashartl can you verify if this is still used or compatible with our Ansible setup of agents?

@0x6178656c
Copy link
Contributor Author

Thank you for the PR, great job! Can you please also update scripts/docker/jenkinsnode/README.md

The README.md needs some overhaul, it is not confirming to the Documentation Guidelines.

@lukashartl can you verify if this is still used or compatible with our Ansible setup of agents?

I read the documentation on the build process and it is actually not clear to me if this Docker image is still used at all?

The documentation states that the Jenkins nodes should have Docker installed, but this is not the case for this image.
https://github.com/ElektraInitiative/libelektra/blob/master/doc/BUILDSERVER.md#adding-a-jenkins-node

I propose the following:

  • If this image is still relevant this should be documented accordingly
  • If this image is no longer used it should be removed from repository

@lukashartl
Copy link
Contributor

@markus2330

@lukashartl can you verify if this is still used or compatible with our Ansible setup of agents?

It is not used for our main build agents. Those are already on bullseye and are using jdk 11. (ansible is also enforcing jdk 11)

I honestly don't know if anyone is still using this image?

@markus2330 markus2330 merged commit 572985c into ElektraInitiative:master Nov 5, 2022
@markus2330 markus2330 mentioned this pull request Nov 5, 2022
3 tasks
@markus2330
Copy link
Contributor

Thank you for the update&testing!

I propose the following:

I agree, I created #4637.

@mpranj mpranj added this to the 0.9.12 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants