Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: run cmake twice #3224

Merged
merged 1 commit into from Nov 17, 2019
Merged

tests: run cmake twice #3224

merged 1 commit into from Nov 17, 2019

Conversation

markus2330
Copy link
Contributor

might improve #2967

Basics

These points need to be fulfilled for every PR:

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy.
  • The PR is rebased with current master.

If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

If you are already Elektra developer:

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and you also
    say that everything is ready to be merged.

@markus2330 markus2330 mentioned this pull request Nov 16, 2019
11 tasks
@dominicjaeger
Copy link
Contributor

I think this is a great idea! Hopefully this really works :)

Is there a reason why we run it exactly twice and not in a loop up to 5 times or similar?

I'd maybe call it "run ctest twice", but doesn't really matter.

@markus2330
Copy link
Contributor Author

Is there a reason why we run it exactly twice and not in a loop up to 5 times or similar?

No, 2 is arbitrary. I started with the lowest number.

I'd maybe call it "run ctest twice", but doesn't really matter.

Thank you, that is actually a typo.

@markus2330
Copy link
Contributor Author

jenkins build libelektra please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants