Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLIB changes #3168

Merged
merged 3 commits into from Nov 9, 2019
Merged

GLIB changes #3168

merged 3 commits into from Nov 9, 2019

Conversation

manuelm
Copy link
Contributor

@manuelm manuelm commented Nov 6, 2019

See #3162
See #3171

@markus2330
Copy link
Contributor

Looks good, please write release notes.

internal change only

I do not know what you mean, this is a change in the public glib API.

@manuelm
Copy link
Contributor Author

manuelm commented Nov 7, 2019

I do not know what you mean, this is a change in the public glib API.

No it's not. No signature changes. No changes in any tests.

edit: I forgot about gelektra_keyset_resize... adapted the release doc entry. and added the keyset iterator adaptions.

@manuelm manuelm changed the title get rid of kdbprivate.h in bindings/tools GLIB changes Nov 7, 2019
@markus2330
Copy link
Contributor

jenkins build libelektra please

2 similar comments
@markus2330
Copy link
Contributor

jenkins build libelektra please

@markus2330
Copy link
Contributor

jenkins build libelektra please

@markus2330
Copy link
Contributor

markus2330 commented Nov 8, 2019

A test fails in Travis:

60/254 Test  #57: testio_glib .................................***Failed    5.08 sec

BINDING TEST-SUITE

==================

test basics
test idle
test timer
testTimerShouldCallbackOnce (warning): measured 316ms, expected 250ms - deviation 66ms.
testTimerShouldCallbackAtIntervals (warning): measured 343ms, expected 250ms - deviation 93ms.
testTimerShouldCallbackAtIntervals (warning): measured 322ms, expected 250ms - deviation 72ms.
testTimerShouldCallbackAtIntervals (warning): measured 338ms, expected 250ms - deviation 88ms.
../src/bindings/io/test/test_timer.c:273: error in testTimerShouldChangeInterval: timer was not called the required amount of times
test file descriptor
test mix

Is it so much slower now? Did you benchmark it?

@manuelm
Copy link
Contributor Author

manuelm commented Nov 8, 2019

I looked at the file. It's not related. It isn't using the glib bindings at all.

There are also no key or keyset structures, so I'm not sure what bindings/io is actually about :-)

edit: I've restarted the test. This time it succeeded. These tests are soo reliable..

edit2: The failure in jenkins is nonsense as well. Just merge as-is.

@dominicjaeger
Copy link
Contributor

edit2: The failure in jenkins is nonsense as well. Just merge as-is.

I've never seen this test case fail before and cannot find it in #2967. Maybe we should add it there.

 27/134 MemCheck  #23: testcpp_contextual_thread ........***Exception: Other  2.59 sec
Running main() from /opt/gtest/googletest/src/gtest_main.cc
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from test_contextual_thread
[ RUN      ] test_contextual_thread.instanciation

/home/jenkins/workspace/libelektra_PR-3168-L5JHIPUUQR3TWFGKHQIDK6HHW6QAMSQXWJC5ZUZMBLDMLTYA2ENA@2/src/bindings/cpp/tests/testcpp_contextual_thread.cpp:70: Failure

Expected equality of these values:
  ks.lookup ("user/hello").getString ()
    Which is: "8"
  "5"
terminate called without an active exception

@markus2330
Copy link
Contributor

jenkins build libelektra please

@markus2330 markus2330 mentioned this pull request Nov 8, 2019
11 tasks
@markus2330 markus2330 merged commit 08b82de into ElektraInitiative:master Nov 9, 2019
@markus2330
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants