New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLIB changes #3168
GLIB changes #3168
Conversation
12d38be
to
3de7d60
Compare
Looks good, please write release notes.
I do not know what you mean, this is a change in the public glib API. |
No it's not. No signature changes. No changes in any tests. edit: I forgot about |
jenkins build libelektra please |
2 similar comments
jenkins build libelektra please |
jenkins build libelektra please |
A test fails in Travis:
Is it so much slower now? Did you benchmark it? |
I looked at the file. It's not related. It isn't using the glib bindings at all. There are also no key or keyset structures, so I'm not sure what bindings/io is actually about :-) edit: I've restarted the test. This time it succeeded. These tests are soo reliable.. edit2: The failure in jenkins is nonsense as well. Just merge as-is. |
I've never seen this test case fail before and cannot find it in #2967. Maybe we should add it there.
|
jenkins build libelektra please |
Thank you! |
See #3162
See #3171