Merge

[dominicjaeger]

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

• Short descriptions should be in the release notes (added as entry in
  doc/news/_preparation_next_release.md which contains _(my name)_)
  Please always add something to the the release notes.
• Longer descriptions should be in documentation or in design decisions.
• Describe details of how you changed the code in commit messages
  (first line should have module: short statement syntax)
• References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

• I added unit tests for my code
• I fixed all affected documentation
• I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
• I updated all meta data (e.g. README.md of plugins and METADATA.ini)
• I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

• Documentation is introductory, concise and good to read
• Examples are well chosen and understandable
• Code is conforming to our Coding Guidelines
• APIs are conforming to our Design Guidelines
• Code is consistent to our Design Decisions

Labels

• Add the "work in progress" label if you do not want the PR to be reviewed yet.
• Add the "ready to merge" label if the build server is happy and also you
  say that everything is ready to be merged.

[dominicjaeger]

I think I'm pretty close to having all tests successful. Currently cmake throws an error because it does not find two functions from libgit2 in the full build. I looked into the cmake files to find the source for the error, but I'm pretty confused at the moment.

We are not allowed to include libgit2 due to the licenses. In the shared build we link to a existing libgit2 on the system. Would we have to include libgit2 in the full build? But we are not allowed to do this?

[markus2330]

I think I'm pretty close to having all tests successful. Currently cmake throws an error because it does not find two functions from libgit2 in the full build. I looked into the cmake files to find the source for the error, but I'm pretty confused at the moment.

Missing functions sounds like too old libgit2. libgit2 in stretch is quite old (also the gitresolver does not work there). Did you add the version check for libgit2? (see gitresolver how to do it)

We are not allowed to include libgit2 due to the licenses. In the shared build we link to a existing libgit2 on the system. Would we have to include libgit2 in the full build? But we are not allowed to do this?

Also the full build only links against the libgit2, so there is no difference.

[markus2330]

The static build might be a problem for some licenses (like one plugin uses a GPL lib and another one uses CDDL) but the problem of the person who compiles Elektra, not ours.

[dominicjaeger]

Did you add the version check for libgit2? (see gitresolver how to do it)

No. But I still don't think it would help.

Missing functions sounds like too old libgit2. libgit2 in stretch is quite old (also the gitresolver does not work there).

As I tried to fix that in between, I pushed the "original" commits that gave me that one libgit error only another time and now other test fail :/

• "remote file operation failed" for docker
• timeout when downloading from homebrew
• markdown tests time out
  ....

Nonetheless, the only two functions I use (git_merge_file and git_merge_file_result_free) have the same parameters through all API versions that are available online. Stretch certainly is part of those versions, too.

[dominicjaeger]

While I'm writing this one artifact is still being built on Jenkins while the stretch package build ended with an error again and I think I need some time to figure this out.

Due to the long building times I'm working on the documentation on another local branch in parallel.

[markus2330]

Nonetheless, the only two functions I use (git_merge_file and git_merge_file_result_free) have the same parameters through all API versions that are available online. Stretch certainly is part of those versions, too.

Ok, good. For @tom-wa some functions were not available in earlier versions at all.

Due to the long building times I'm working on the documentation on another local branch in parallel.

Yes, very good idea! We are busy working on migrating to the build server to faster hardware but unfortunately it still takes time.

[markus2330]

The formatting check seems to fail here in a later stage (not in the formatting stage)?

[dominicjaeger]

The formatting check seems to fail here in a later stage (not in the formatting stage)?

Yes.

diff --git a/src/plugins/specload/specload/remove.quickdump b/src/plugins/specload/specload/remove.quickdump$           
 index ccedf5000..e69de29bb 100644$
 Binary files a/src/plugins/specload/specload/remove.quickdump and b/src/plugins     /specload/specload/remove.quickdump differ

The only thing I have been changing for the last couple of days is the last commit for libgit linking and all sorts of errors (that I comprehend partly and partly not) seem to randomly appear.

Locally (with run_dev_env) everything compiles and all the tests run. And then

• one time a single build on jenkins complains about linking problems
• another time some resources on docker are busy until timeout
• another time some specload binary makes the format test fail
• suddenly some of my tests segfault on cirrus

I'm copying the error messages in hope to find patterns and report them if I think it's not my fault. Nonetheless, the last days with the continuous integration have been tough.

[markus2330]

Please report it upstream even if you cannot reproduce it. More than not getting answers cannot happen. You can extend the bug report once you know more.

[dominicjaeger]

jenkins build libelektra please

[dominicjaeger]

Please report it upstream even if you cannot reproduce it.

Done here.

[markus2330]

Thank you! Also give them version information and on which systems the problem appeared (and where it works).

[dominicjaeger]

Also give them version information

I added the Elektra version. Which version do you think is missing?

and on which systems the problem appeared (and where it works).

I don't know what you mean exactly. What fails is our build artifacts and all except the debian buster build are website related. And the Debian buster build is what I mentioned in the issue?

[markus2330]

Which version do you think is missing?

Of libgit2.

And the Debian buster build is what I mentioned in the issue?

Yes, but I thought there are several distributions some of which the error occurs and others where it does not.

What you also did not say that it sometimes succeeds and sometimes fails.

The reply basically says the same what we already said. Maybe you sometimes pushed wrong commits which caused this problem. The email notification sometimes said you pushed 0 commits, maybe something went wrong?

[dominicjaeger]

jenkins build libelektra please

[dominicjaeger]

jenkins build libelektra please

[dominicjaeger]

Of libgit2.

It is in the the output of the dpkg command that I posted there?

Yes, but I thought there are several distributions some of which the error occurs and others where it does not.

There was a stretch artifcat before I think?

What you also did not say that it sometimes succeeds and sometimes fails.

IIRC I got to the stage the undefined references in the debian buster artifact was the only problem maybe once or twice.

The email notification sometimes said you pushed 0 commits, maybe something went wrong?

Maybe this is from amending to the last commit + force push?

[dominicjaeger]

jenkins build libelektra please

[dominicjaeger]

Superseded by #3105.