-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename keyIsDirectBelow to keyIsDirectlyBelow #2988
Merged
markus2330
merged 6 commits into
ElektraInitiative:master
from
PhilippGackstatter:rename_keyisdirectbelow
Oct 6, 2019
Merged
Rename keyIsDirectBelow to keyIsDirectlyBelow #2988
markus2330
merged 6 commits into
ElektraInitiative:master
from
PhilippGackstatter:rename_keyisdirectbelow
Oct 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for creating this PR! |
The build server is happy now. Unfortunately, there is now a merge conflict. Can you please rebase? |
PhilippGackstatter
force-pushed
the
rename_keyisdirectbelow
branch
from
October 2, 2019 07:03
dbd9de0
to
be5381a
Compare
Something went wrong here, the file "src/bindings/haskell/src/Elektra/Key.chs" was added (but it should stay removed). |
jenkins build libelektra please |
2 similar comments
jenkins build libelektra please |
jenkins build libelektra please |
Thank you, you have really great progress! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
keyIsDirectBelow
tokeyIsDirectlyBelow
as proposed in #2730 and #2979.So this takes care of the bindings as well. For at least CPP, Java, Haskell and Rust this is a breaking change.
Basics
Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:
doc/news/_preparation_next_release.md
which contains_(my name)_
)Please always add something to the the release notes.
(first line should have
module: short statement
syntax)close #X
, should be in the commit messages.Checklist
Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.
Review
Reviewers will usually check the following:
Labels
say that everything is ready to be merged.