New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile for Ubuntu-Bionic #2932
Conversation
Thank you for creating this PR! Please do not forget to add a line to the release notes so that the build can succeed. The checklist you removed when creating the PR would have helped to not forget such things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request. Looks good, as far as I can tell. I added some comments about minor details that could be improved (according to my opinion 😊).
You can also fix the Jenkinsfile here. |
Why do i get broken links check? |
The failing link check for the URL https://debian-stretch-repo.libelektra.org is expected behavior, since the server hosting the Debian package repository ( |
@Mistreated: please put https://debian-stretch-repo.libelektra.org to the whitelist in tests/linkchecker.whitelist so that we do not always get failing tests when a7 is down (webdemo is already in the whitelist, it is also hosted on a7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some problems.
Every time i get a different error not related to Ubuntu Bionic. |
Please tell us which errors you get. Please open new issues or report to existing issues.
Yes, a lot more! Did you already read doc/BUILDSERVER.md? |
I created an issue that should keep track of the reasons why the Jenkins build fails here.
It would probably make sense to temporarily comment some of the stages in the Jenkinsfile, while you figure out how to build the Ubuntu packages. For example, as far as I know, Jenkins does not need to execute either the „main builds“ nor the „full builds” stage to build packages: libelektra/scripts/jenkins/Jenkinsfile Lines 147 to 155 in 4186db4
. Not executing these stages should allow you to figure out how to build packages for Ubuntu much faster. |
@ingwinlu was so nice to point out that https://github.com/ElektraInitiative/buildserver/blob/master/compose/frontend/docker-compose.yml#L63 is responsible for publishing the repos. So we need to also improve this to have several repos. |
Yes, so I should make a tasks for building and testing for ubuntu bionic? |
Please proofread the sentences you write, the sentences are often confusing. "Yes, so I should make a tasks for building and testing for ubuntu bionic?".
Trying to interpolate what you might have meant: Yes, please create issue(s) about building and publishing the Debian packages for Ubuntu bionic. |
After another look, I think you can also temporarily comment this part of the main stage: libelektra/scripts/jenkins/Jenkinsfile Lines 1028 to 1029 in f3203b1
, so Jenkins does not build any of the artifacts for the website, and Web UI. |
Added git-buildpackage
@@ -14,6 +14,7 @@ RUN apt-get update && apt-get -y install \ | |||
discount \ | |||
doxygen \ | |||
git \ | |||
git-buildpackage \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting
#2924
Tested locally.