Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for Ubuntu-Bionic #2932

Closed
wants to merge 11 commits into from
Closed

Dockerfile for Ubuntu-Bionic #2932

wants to merge 11 commits into from

Conversation

dbulatovic
Copy link
Contributor

#2924
Tested locally.

@markus2330
Copy link
Contributor

markus2330 commented Sep 7, 2019

Thank you for creating this PR!

Please do not forget to add a line to the release notes so that the build can succeed. The checklist you removed when creating the PR would have helped to not forget such things.

Copy link
Member

@sanssecours sanssecours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Looks good, as far as I can tell. I added some comments about minor details that could be improved (according to my opinion 😊).

scripts/docker/ubuntu/bionic/Dockerfile Show resolved Hide resolved
scripts/docker/ubuntu/bionic/Dockerfile Outdated Show resolved Hide resolved
scripts/docker/ubuntu/bionic/Dockerfile Outdated Show resolved Hide resolved
doc/news/_preparation_next_release.md Outdated Show resolved Hide resolved
@markus2330
Copy link
Contributor

You can also fix the Jenkinsfile here.

@dbulatovic
Copy link
Contributor Author

Why do i get broken links check?
Should it do anyhting else except building debian packages?

@sanssecours
Copy link
Member

Why do i get broken links check?

The failing link check for the URL https://debian-stretch-repo.libelektra.org is expected behavior, since the server hosting the Debian package repository (a7) is currently down. For more information, please take a look at issue #160.

@markus2330
Copy link
Contributor

@Mistreated: please put https://debian-stretch-repo.libelektra.org to the whitelist in tests/linkchecker.whitelist so that we do not always get failing tests when a7 is down (webdemo is already in the whitelist, it is also hosted on a7)

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some problems.

scripts/jenkins/Jenkinsfile Outdated Show resolved Hide resolved
scripts/jenkins/Jenkinsfile Outdated Show resolved Hide resolved
@dbulatovic
Copy link
Contributor Author

Every time i get a different error not related to Ubuntu Bionic.
Can I get some more info about this?
Should Jenkins do anything else except buildDebianpackeges()?

@markus2330
Copy link
Contributor

Every time i get a different error not related to Ubuntu Bionic.

Please tell us which errors you get. Please open new issues or report to existing issues.

Should Jenkins do anything else except buildDebianpackeges()?

Yes, a lot more! Did you already read doc/BUILDSERVER.md?

@sanssecours sanssecours mentioned this pull request Sep 16, 2019
11 tasks
@sanssecours
Copy link
Member

Every time i get a different error not related to Ubuntu Bionic.

Please tell us which errors you get. Please open new issues or report to existing issues.

I created an issue that should keep track of the reasons why the Jenkins build fails here.

Can I get some more info about this?

It would probably make sense to temporarily comment some of the stages in the Jenkinsfile, while you figure out how to build the Ubuntu packages. For example, as far as I know, Jenkins does not need to execute either the „main builds“ nor the „full builds” stage to build packages:

stage("Main builds") {
milestone label: "Main builds"
parallel generateMainBuildStages()
}
stage("Full builds") {
milestone label: "Full builds"
parallel generateFullBuildStages()
}

. Not executing these stages should allow you to figure out how to build packages for Ubuntu much faster.

@markus2330
Copy link
Contributor

@ingwinlu was so nice to point out that https://github.com/ElektraInitiative/buildserver/blob/master/compose/frontend/docker-compose.yml#L63 is responsible for publishing the repos. So we need to also improve this to have several repos.

@dbulatovic
Copy link
Contributor Author

dbulatovic commented Sep 17, 2019

Yes, a lot more! Did you already read doc/BUILDSERVER.md?

Yes, so I should make a tasks for building and testing for ubuntu bionic?

@markus2330
Copy link
Contributor

Please proofread the sentences you write, the sentences are often confusing. "Yes, so I should make a tasks for building and testing for ubuntu bionic?".

  • Do you mean (GitHub) issue with "task"?
  • Do you mean building the Debian Package for Ubuntu bionic?
  • What do you mean with testing here?

Trying to interpolate what you might have meant: Yes, please create issue(s) about building and publishing the Debian packages for Ubuntu bionic.

@sanssecours
Copy link
Member

After another look, I think you can also temporarily comment this part of the main stage:

tasks << buildWebsite()
tasks << buildWebUI()

, so Jenkins does not build any of the artifacts for the website, and Web UI.

@@ -14,6 +14,7 @@ RUN apt-get update && apt-get -y install \
discount \
doxygen \
git \
git-buildpackage \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants