Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix color completition #2836

Merged
merged 2 commits into from Jul 31, 2019
Merged

fix color completition #2836

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8166fe1
fix color completition
edusantana Jul 30, 2019
8db8ebf
fix bash completion
edusantana Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/kdb-bash-completion
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ _kdb() {
# only kdb was entered yet, print a list of available commands
if [[ $COMP_CWORD -eq 1 ]]; then
local IFS=$'\n'
local commands=($(${kdbpath} 2> /dev/null | sed -e '0,/^Known commands are/d' | awk '{print $1}'))
local commands=($(${kdbpath} 2> /dev/null | sed -e '0,/^Known commands are/d' | awk '{print $1}' | sed -r "s/\x1B\[([0-9]{1,3}((;[0-9]{1,3})*)?)?[m|K]//g" ))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use the kdb subcommand list-commands to simplify this code:

Suggested change
local commands=($(${kdbpath} 2> /dev/null | sed -e '0,/^Known commands are/d' | awk '{print $1}' | sed -r "s/\x1B\[([0-9]{1,3}((;[0-9]{1,3})*)?)?[m|K]//g" ))
local commands=($(${kdbpath} list-commands))

.

COMPREPLY=($(compgen -W '${commands[@]}' -- "${cur}"))
return
fi
Expand Down