Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmapstorage: add import/export compatibility #2639

Merged
merged 27 commits into from Apr 22, 2019

Conversation

mpranj
Copy link
Member

@mpranj mpranj commented Apr 20, 2019

Closes #2419.

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see doc/CODING.md)
  • meta data is updated (e.g. README.md of plugins and doc/METADATA.md)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@@ -253,6 +253,11 @@ The following section lists news about the [modules](https://www.libelektra.org/
- [cache](https://www.libelektra.org/plugins/cache) is a new global caching plugin. It uses [mmapstorage](https://www.libelektra.org/plugins/mmapstorage) as its storage backend and lazily stores keysets from previous ´kdbGet()´ calls. We added initial support for the default resolver and multifile resolver. _(Mihael Pranjić)_
- Add check of resolved filenames, fixes false cache hits. _(Mihael Pranjić)_

### mmapstorage

- [mmapstorage](https://www.libelektra.org/plugins/mmapstorage) is now able to persist the Global KeySet, which is used by the `cache` plugin. _(Mihael Pranjić)_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done already, I forgot to mention it previously.

@mpranj mpranj added this to the 0.8.27 milestone Apr 21, 2019
@mpranj
Copy link
Member Author

mpranj commented Apr 21, 2019

@markus2330 done!

The builds should pass, the last change was only a one line docu fix.

@markus2330 markus2330 merged commit 096900b into ElektraInitiative:master Apr 22, 2019
@markus2330
Copy link
Contributor

Thank you very much for the fix!

@mpranj mpranj deleted the mmapstorage-export branch April 21, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmapstorage doesn't work with kdb export
2 participants