test: Fix is_not_rw_storage

[llukask]

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

• Short descriptions should be in the release notes (added as entry in
  doc/news/_preparation_next_release.md which contains _(my name)_)
  Please always add something to the the release notes.
• Longer descriptions should be in documentation or in design decisions.
• Describe details of how you changed the code in commit messages
  (first line should have module: short statement syntax)
• References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

• I added unit tests
• I ran all tests locally and everything went fine
• affected documentation is fixed
• I added code comments, logging, and assertions (see doc/CODING.md)
• meta data is updated (e.g. README.md of plugins and doc/METADATA.md)

Review

Remove the line below and add the "work in progress" label if you do
not want the PR to be reviewed:

@markus2330 please review my pull request

Merging

Please add the "ready to merge" label when the build server and you say
that everything is ready to be merged.

[markus2330]

Thank you for working on this! Seems like you already solved follow-up problems that turned up after you fixed the function?

[kodebach]

Looks good to me (apart from the failing tests)

[llukask]

@markus2330 Yes to get the tests to run again, I did manually exclude the following plugins from is_not_rw_storage:

• desktop, c, cpptemplate, specload because they are not really rw-storage plugins
• mmapstorageand mmapstorage_crc because they can't export to stdout (mmapstorage doesn't work with kdb export #2419)
• tcl, mini, simpleini because they can't deal with values at the root of the exported hierarchy (see my comment on is_not_rw_storage broken #2423)
• yambi because it does not seem to export anything at all

[llukask]

I added test files for xerces and excluded yamlcpp because it does not export anything

[sanssecours]

yambi because it does not seem to export anything at all

YAMBi (Yan LR, YAwn, and YAy PEG) do not include write support. They all use YAML Smith to write data back to a YAML file.

…and excluded yamlcpp because it does not export anything.

Are you sure about that? I tried the following, which seems to work:

kdb set user/tests/key value
kdb export user/tests yamlcpp
#> key: value
kdb export user/tests/key yamlcpp
#> value

.

[llukask]

@sanssecours

…and excluded yamlcpp because it does not export anything.
Yes, thats not correct.

The problem I encountered with yamlcpp is that like yajl it cannot hold values in directories.

i.e.

kdb set user/tests root
kdb set user/tests/key hello
kdb export user/tests yamlcpp

gives

key: hello

but if you omit setting user/tests/key exporting gives just root

[sanssecours]

The problem I encountered with yamlcpp is that like yajl it cannot hold values in directories.

Thank you for the clarification. For this purpose YAML CPP requires the Directory Value plugin. Unfortunately kdb export ignores required plugins 😢.

[markus2330]

To get this PR ready, I think we need to exclude these plugins now. But please mark that they should be readded (directly next to the list and in doc/todo/TESTING).

The problem I encountered with yamlcpp is that like yajl it cannot hold values in directories.

yajl should now be able to do so. The PR was merged recently.

[markus2330]

Any progress here?

[markus2330]

@kodebach can you take over #2423 and finish this PR?

[kodebach]

I'll do it once I've finished with #3102. (no PR yet, the code is still quite chaotic and broken)

[kodebach]

@markus2330 I rebased the branch, let's see what the build servers say...

[kodebach]

I added the test data for toml and kconfig and disabled the tests for them. I think this PR should now be done, let's see if the build server agrees...

@bauhaus93 You should probably try to fix the storage tests for the toml plugin, if we want to use it as a default storage plugin...

[markus2330]

Great job! 💖

[mpranj]

Thank you @llukask for fixing this and @kodebach for finishing it up! 🚀 Great job! 🥇