Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippet-sharing: fixes + tutorial improvements #1163

Merged
merged 4 commits into from
Dec 3, 2016
Merged

snippet-sharing: fixes + tutorial improvements #1163

merged 4 commits into from
Dec 3, 2016

Conversation

Namoshek
Copy link
Contributor

@Namoshek Namoshek commented Dec 3, 2016

Purpose

This PR solves the issues in #1160.

Checklist

Please only check relevant points.
For docu fixes, spell checking and similar nothing
needs to be checked.

  • commit messages are fine (with references to issues)
  • I ran all tests and everything went fine
  • affected documentation is fixed
  • I added unit tests
  • I added code comments, logging, and assertions
  • meta data is updated (e.g. README.md of plugins)

@markus2330 please review my pull request

@@ -146,14 +161,21 @@ configuration:
> kdb set system/sw/elektra/restbackend/#0/current/cppcms/http/script_names/#0 "/"
```

Note: here we have not used the option `-N system` because the CppCMS configuration is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to do here differently? Maybe validation will be added later? Or we should always do validation (even when setting per namespace).

@markus2330 markus2330 merged commit 198bb88 into ElektraInitiative:master Dec 3, 2016
@markus2330
Copy link
Contributor

Thank you! The question was too general to address in this PR, should we open an extra issue for this?

@Namoshek
Copy link
Contributor Author

Namoshek commented Dec 3, 2016

You are actually right, I could have written it with some view into the future.

Doing validation always seems a good idea and shouldn't be difficult to implement for the kdb tool.

@Namoshek Namoshek deleted the restservices-tutorial-improvements branch December 3, 2016 17:36
@markus2330
Copy link
Contributor

Thanks, you are right, I opened #1164.

Btw. there is also #886 which would allow you to always issue kdb global-mount (if other plugins are already mounted, it would be a NOP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants