Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Remove Blossoms from Frontend #1297

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andreicristian97
Copy link
Contributor

@andreicristian97 andreicristian97 commented Apr 17, 2024

Summary

  • Removed text in the guided tour that referenced blossoms.
  • Removed code in frontend that would award blossoms to the user at the end of the guided tour.

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@andreicristian97 andreicristian97 linked an issue Apr 17, 2024 that may be closed by this pull request
2 tasks
@andreicristian97
Copy link
Contributor Author

One open question:
As it is currently intended for the Blossoms to be reintroduced later, the relevant code pieces were left commented in the components with a comment explaining the situation. Is this ok or should the code be fully removed right now?

@andreicristian97 andreicristian97 self-assigned this Apr 17, 2024
@andreicristian97 andreicristian97 added the please review Review by unspecified person requested label Apr 17, 2024
Copy link
Contributor

@hatchla hatchla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@markus2330
Copy link
Contributor

As it is currently intended for the Blossoms to be reintroduced later, the relevant code pieces were left commented in the components with a comment explaining the situation. Is this ok or should the code be fully removed right now?

It would be better to completely remove it, git easily allows to restore it anyway.

A TODO in the code is definitely not needed as it would be a completely new feature if ever reintroduced.

@andreicristian97
Copy link
Contributor Author

As it is currently intended for the Blossoms to be reintroduced later, the relevant code pieces were left commented in the components with a comment explaining the situation. Is this ok or should the code be fully removed right now?

It would be better to completely remove it, git easily allows to restore it anyway.

A TODO in the code is definitely not needed as it would be a completely new feature if ever reintroduced.

Commented code has been removed.

What is still present are the other files relevant to blossoms: gainBlossom.ts and the translation files blossoms.json
Should they be removed as well as they are currently not used?

@markus2330
Copy link
Contributor

Yes, please go ahead and remove everything you found related to blossoms (except of backend, where we leave it for now).

@andreicristian97
Copy link
Contributor Author

Removed all blossom-related files and references from the Frontend

@andreicristian97
Copy link
Contributor Author

jenkins build please

Copy link
Contributor

@chr-schr chr-schr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

@chr-schr chr-schr mentioned this pull request Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
please review Review by unspecified person requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove blossoms from frontend
5 participants