-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃敡 Instrument gateway process #256
Conversation
@@ -68,6 +70,17 @@ func NewGateway(configProvider *config.Provider) (*Gateway, error) { | |||
|
|||
// Run starts and runs the gateway according to given configuration | |||
func (gw *Gateway) Run(ctx context.Context) error { | |||
// Instrument the gateway process | |||
err := host.Start() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call some Stop() method as well? I'm wondering how this would work on service shutdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call some Stop() method as well?
nope!
otel api is callback based, basically the host.Start
call registers callback on the global otel providers.
@@ -9,6 +9,8 @@ import ( | |||
|
|||
"github.com/EinStack/glide/pkg/routers" | |||
"github.com/EinStack/glide/pkg/version" | |||
"go.opentelemetry.io/contrib/instrumentation/host" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This's actually very they have in-proc metrics as standard instrumentations 馃檶
* develop: 馃敡 馃挜 EinStack#235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (EinStack#236) 馃敡 EinStack#220 Instrument API server (EinStack#255) 馃敡 EinStack#248 Disable span and metrics by default (EinStack#254)
@roma-glushko PTAL |
Closes #224