Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敡 #238 Implements human readable durations in config #253

Merged
merged 4 commits into from
May 22, 2024
Merged

馃敡 #238 Implements human readable durations in config #253

merged 4 commits into from
May 22, 2024

Conversation

ppmdo
Copy link
Contributor

@ppmdo ppmdo commented May 9, 2024

  • Render all durations as human readable strings
  • Adds tests
  • Updates docs
grafik

@ppmdo ppmdo changed the title Implements human readable durations in config, fixes #238 #238 Implements human readable durations in config May 9, 2024
@roma-glushko roma-glushko added type:enhancement New feature or request area:config labels May 12, 2024
@roma-glushko roma-glushko changed the title #238 Implements human readable durations in config 馃敡 #238 Implements human readable durations in config May 12, 2024
roma-glushko
roma-glushko approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@roma-glushko roma-glushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Pablo 馃憤
Would you be able to fix merge conflicts? 馃檹

@ppmdo
Copy link
Contributor Author

ppmdo commented May 13, 2024 •
edited

Conflicts fixed.
Had to adjust some tests from the develop branch.

@roma-glushko roma-glushko merged commit 03f1805 into EinStack:develop May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roma-glushko roma-glushko roma-glushko approved these changes

Assignees
No one assigned
Labels
area:config type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppmdo @roma-glushko