Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding OrdinalRidge and LAD regressors #687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2021

This PR adds two new learners OrdinalRidge and LAD from mord library .

There are two things I would like to mention here:

  • These learners do not have rescaled version because the predictions by these learners are already transformed within the range of zero to maximum of the label. Rescaling these transformed predictions makes the two predictions not correlate to each other. Here's the graph I plot between the predictions made by the OrdinalRidge and RescaledOrdinalRidge.
  • In the unit tests, all the linear/non-linear regressors have 95% correlation with the labels. However, due to the transformed predictions by these learners, the correlation is only 0.85. I was trying to see if make_regression function would generate the data with labels in the given range (here I want the labels to be not less than 0 because predictions will have minimum 0 value), but I could not find such functionality.

I would like to get feedback on these and will work on making this better.

@ghost ghost requested review from desilinguist, aoifecahill and mulhod April 7, 2021 01:36
@ghost ghost linked an issue Apr 7, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #687 (54def9d) into main (391cf34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          63       63           
  Lines        9098     9102    +4     
=======================================
+ Hits         8812     8816    +4     
  Misses        286      286           
Impacted Files Coverage Δ
skll/learner/__init__.py 97.09% <100.00%> (+<0.01%) ⬆️
tests/test_regression.py 99.64% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391cf34...54def9d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding ordinal regression learners
0 participants