Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve performance #124

wants to merge 1 commit into from

Conversation

DLPerf
Copy link

@DLPerf DLPerf commented Aug 17, 2021

If tf.zeros is created before loop, the graph will be more concise.

@DLPerf
Copy link
Author

DLPerf commented Aug 19, 2021

Fix for issue #123

@DLPerf
Copy link
Author

DLPerf commented Sep 3, 2021

@rsennrich Hi, my friend, could you deal with the PR asap?

@rsennrich
Copy link
Collaborator

thank you for your pull request. I have two comments:

  • please test code before opening a PR. This PR contains a syntax error.
  • I'm happy to accept PRs with efficiency improvements, but will give higher priority to PRs that actually demonstrate an improvement. Is there a use case where this PR has a measurable effect on performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DLPerf @rsennrich