-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio): enforce rules for custom switches when setting up in the UI. #4994
base: main
Are you sure you want to change the base?
Conversation
Overall very nice (i realize this is WIP)
I will wait for that change to be merged to address #4989, since both need similar functions added |
Done.
I think this is fixed now.
Moved the ones that aren't UI specific. I've also renamed FS_START_UP to FS_START_ON and FS_START_DOWN to FS_START_OFF to avoid confusion and because the previous names were backwards. E.G. if you use one of the custom switches in a SF then the ON state shows as SW DOWN, not UP which is consistent with usage for normal switches. |
Perfect ! |
For completeness, I've added an option to set the startup state of a group to 'Off'. |
Successfully tested on T20V2 |
fa84c43
to
e12addf
Compare
Remove unnecessary code. Fix switch start position display to match actual state. Fix issues with group startup switch logic.
75b9378
to
c5f0921
Compare
Fixes #4990
Changes to the UI for setting up custom function switches to prevent invalid setup.