-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): allow state of Sticky LS to persist across reboot or EM. #4978
base: main
Are you sure you want to change the base?
Conversation
Persistence on EM makes a lot of sense, but I believe not at all on reboot imho. |
On EM, definitely. Across reboot... only as an option. There are times where the LS being able to remember it's state (just like with customisable switches) would be advantageous. |
Could you describe such a scenario? |
For the same reason as with customisable switches... when using momentary switches as 2POS, and remembering the state across reboots. |
That works for customizable switches because they have a led to indicate the state. Bad idea for LS I think |
Even as an option, rather than the default? 🤔 So what happens when I use a SF to adjust a GV to get that persistence? Is that not dangerous also (with more steps, and loss of both SFs and GVs in the process). |
I've added an option flag so users can decide if a Sticky LS should persist across reboots. |
b400aae
to
83524b1
Compare
83524b1
to
590c028
Compare
590c028
to
04de7a9
Compare
Persistence across EM is useful when recovering model state.
Not sure whether persistence on reboot is a good idea or not - opinions?