Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): allow state of Sticky LS to persist across reboot or EM. #4978

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented May 7, 2024

Persistence across EM is useful when recovering model state.

Not sure whether persistence on reboot is a good idea or not - opinions?

@3djc
Copy link
Collaborator

3djc commented May 7, 2024

Persistence on EM makes a lot of sense, but I believe not at all on reboot imho.

@pfeerick
Copy link
Member

pfeerick commented May 7, 2024

On EM, definitely. Across reboot... only as an option. There are times where the LS being able to remember it's state (just like with customisable switches) would be advantageous.

@3djc
Copy link
Collaborator

3djc commented May 7, 2024

Could you describe such a scenario?

@pfeerick
Copy link
Member

pfeerick commented May 7, 2024

For the same reason as with customisable switches... when using momentary switches as 2POS, and remembering the state across reboots.

@3djc
Copy link
Collaborator

3djc commented May 7, 2024

That works for customizable switches because they have a led to indicate the state. Bad idea for LS I think

@pfeerick
Copy link
Member

pfeerick commented May 7, 2024

Even as an option, rather than the default? 🤔 So what happens when I use a SF to adjust a GV to get that persistence? Is that not dangerous also (with more steps, and loss of both SFs and GVs in the process).

@philmoz
Copy link
Collaborator Author

philmoz commented May 7, 2024

I've added an option flag so users can decide if a Sticky LS should persist across reboots.

@philmoz philmoz force-pushed the persist-sticky-ls branch 2 times, most recently from b400aae to 83524b1 Compare May 14, 2024 06:32
@pfeerick pfeerick added this to the 2.11 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants