Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bw): add radio option to invert LCD/OLED display for 128x64 B&W screens. #4933

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 27, 2024

Tested on OLED (T14 and T20v2) and LCD (X7, MT12 and TLite).

@philmoz
Copy link
Collaborator Author

philmoz commented Apr 27, 2024

I moved the option to the hardware tab as suggested in discord. Thanks @pfeerick

screenshot_t20v2_24-04-28_09-48-34

@inventor7777
Copy link

Will this be added to the final 2.10, or do I have to get the special version to get this feature?

@pfeerick
Copy link
Member

pfeerick commented Apr 28, 2024 via email

@inventor7777
Copy link

2.10 is feature complete, so this will be in 2.11 if merged.

Sounds good! I hope it is added eventually, because I could definitely use it.

@pfeerick pfeerick changed the title feat(B&W): add radio option to invert LCD/OLED display for 128x64 B&W screens. feat(bw): add radio option to invert LCD/OLED display for 128x64 B&W screens. May 2, 2024
@arthurson
Copy link

i remembered this function has been required on discord around years ago , so happy everyone can use it now

@DuckyScr
Copy link

DuckyScr commented May 13, 2024

Hi, I have downloaded the build and it doesnt have persistance. I have been waiting for this and also asked on discord so it is really good feature for me and whenever I chek it and it toggles and works. BUT after I turn the radio off and then on it is not checked and not working. Tested on RadioMaster Boxer

@philmoz
Copy link
Collaborator Author

philmoz commented May 13, 2024

It's working on the B&W radios I have; but I don't have a boxer to test on.

Can you turn on the option and before restarting copy the RADIO/radio.yaml file off the radio.
Then restart and copy the same file off the radio again.
Please upload both file here in a ZIP file.

@DuckyScr
Copy link

DuckyScr commented May 14, 2024

Archive.zip
here it is and what Ive found out is that the check button in hardware tab is still checked after restart, just the screen is not inverted and btw my sd card content is on version 2.10.0 if that helps :)

@philmoz
Copy link
Collaborator Author

philmoz commented May 14, 2024

Thanks for that - can you try the version in this ZIP file please.

boxer_lcdinvert_240514.bin.zip

@DuckyScr
Copy link

Archive.zip
still the same issue, there is the yml

@philmoz
Copy link
Collaborator Author

philmoz commented May 14, 2024

Can you confirm - after a reboot if you turn the option off and back on then the screen inverts?

@DuckyScr
Copy link

Yes, that is exactly what it does

@philmoz
Copy link
Collaborator Author

philmoz commented May 14, 2024

Thanks.again - here's another firmware to try (no need to upload the radio.yaml files).

boxer_invert_try2.bin.zip

@DuckyScr
Copy link

still the same issue

@3djc
Copy link
Collaborator

3djc commented May 14, 2024

Working fine here, even with your radio.yml

https://photos.app.goo.gl/nBNZbu6kgghicmtF7

@DuckyScr
Copy link

And what version of sdcard content you have?

@3djc
Copy link
Collaborator

3djc commented May 14, 2024

It doesn't matter there, only radio and models are read at that stage, but if you post a full copy of your sd, I can try it

@DuckyScr
Copy link

Ok so I'll try to find some issues or smth that woukd cause the problem. Thanks for help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants