Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter higherrank results if not allowed #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

willgearty
Copy link

In some cases (see "Leptotyphlops conjunctus"), the first result from get_gbifid_ is a "HIGHERRANK" match, even when there are also exact matches. Currently the function doesn't filter out this match, and if it has an "ACCEPTED" status, it'll be selected by the function, but then filtered out later, resulting in "No matching species concept!" even though there may have been species matches. This filters out the "HIGHERRANK" matches beforehand if higherrank = TRUE to prevent this.

I also added some additional checks in the if loops to make sure there are still matches before we check them for various things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant