Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): archived resources guidelines #6282

Merged
merged 10 commits into from
Oct 26, 2021
Merged

docs(contributing): archived resources guidelines #6282

merged 10 commits into from
Oct 26, 2021

Conversation

LuigiImVector
Copy link
Member

What does this PR do?

Add info | Improve repo

For resources

Description

Looking at the @davorpa' suggestions in #6276 about the archived link I think that I thought it necessary to add another example to the CONTRIBUTING file about this.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

davorpa
davorpa requested changes Oct 16, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING-it.md Outdated Show resolved Hide resolved
CONTRIBUTING-it.md Outdated Show resolved Hide resolved
@davorpa
Copy link
Member

davorpa commented Oct 17, 2021

First introduction at #5464 (comment)

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 17, 2021
LuigiImVector and others added 4 commits October 17, 2021 10:17
@LuigiImVector @davorpa
Update CONTRIBUTING.md
4789594 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@LuigiImVector @davorpa
Update CONTRIBUTING.md
9cacbce 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@LuigiImVector @davorpa
Update CONTRIBUTING-it.md
d62b423 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@LuigiImVector
Update CONTRIBUTING.md
5a6cd7c
@LuigiImVector
Copy link
Member Author

Thanks @davorpa and @CleanMachine1 for the suggestions.

davorpa
davorpa requested changes Oct 17, 2021
View reviewed changes
CONTRIBUTING-it.md Outdated Show resolved Hide resolved
@eshellman eshellman mentioned this pull request Oct 17, 2021
Closed
@eshellman
Copy link
Collaborator

Discussion in #6301

@eshellman eshellman added 👥 discussion This Repo is guided by its community! Let's talk! and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 17, 2021
@davorpa davorpa added the New Feature New feature / enhancement / translation... label Oct 17, 2021
CleanMachine1
CleanMachine1 reviewed Oct 18, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 20, 2021
LuigiImVector and others added 2 commits October 21, 2021 13:12
@LuigiImVector @CleanMachine1
Update CONTRIBUTING.md
b0c52df 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@LuigiImVector
Sync translation
f76285d
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Oct 21, 2021
@davorpa
feat(docs): archived guidelines ES
23a0e82 
Translate the "archived" guideline note to spanish

Refers to issue EbookFoundation#6301
Refers to implementing proposal  EbookFoundation#6282
@davorpa
Copy link
Member

davorpa commented Oct 22, 2021

Maybe better update PR title with something a bit meaningful like: docs(contributing): archived resources guidelines?

@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 22, 2021
@LuigiImVector LuigiImVector changed the title Update CONTRIBUTING docs(contributing): archived resources guidelines Oct 22, 2021
@LuigiImVector
Copy link
Member Author

Without creating a new PR I added the name of "RIP Tutorial" where it talks about "Goalkicker".
See #6153

@davorpa

This comment has been minimized.

Sign in to view
@eshellman
Copy link
Collaborator

I think this has stewed long enough. Nice work everyone!

@eshellman eshellman merged commit 9266b59 into EbookFoundation:master Oct 26, 2021
@davorpa davorpa mentioned this pull request Oct 26, 2021
Merged
2 tasks
eshellman pushed a commit that referenced this pull request Oct 26, 2021
@davorpa
feat(docs): archived guidelines ES (#6454)
82f97a7 
Translate the "archived" guideline note to spanish

Refers to issue #6301
Refers to implementing proposal  #6282
@davorpa davorpa mentioned this pull request Oct 28, 2021
Merged
2 tasks
davorpa referenced this pull request Oct 30, 2021
@genepride
Update CONTRIBUTING-fil.md
e0401f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@davorpa davorpa davorpa approved these changes

@eshellman eshellman Awaiting requested review from eshellman

Assignees

@davorpa davorpa

@LuigiImVector LuigiImVector

Labels
👥 discussion This Repo is guided by its community! Let's talk! New Feature New feature / enhancement / translation...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LuigiImVector @davorpa @eshellman @CleanMachine1