Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added django course #6056

Merged
merged 5 commits into from Oct 10, 2021
Merged

added django course #6056

merged 5 commits into from Oct 10, 2021

Conversation

ichbinmeraj
Copy link
Contributor

added django persian taught course to free-courses-fa_IR

added django persian taught course to free-courses-fa_IR
@eshellman
Copy link
Collaborator

It's usually not helpful to add a category for a single resource. Try to find another category, or see if there are other books in our lists that would fit into your category. Put it in the Python section.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 8, 2021
changed single video url to playlist url
Copy link
Contributor Author

@ichbinmeraj ichbinmeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed single video url to playlist url

@eshellman
Copy link
Collaborator

I would put this in the python section

@davorpa davorpa added the linter error Please, correct build errors found by linter! label Oct 9, 2021
@@ -14,6 +14,7 @@
* [Laravel](#laravel)
* [Yii](#yii)
* [Python](#python)
* [Django](#django)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually not helpful to add a category for a single resource. Try to find another category, or see if there are other books in our lists that would fit into your category. Put it in the Python section.

It's a fact that exists in other listings, and then helps with #4579 consistence task, I thought.

add one more persian taught django course and fixed blank lines order
Copy link
Contributor Author

@ichbinmeraj ichbinmeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@davorpa davorpa self-requested a review October 9, 2021 19:36
@davorpa davorpa removed the linter error Please, correct build errors found by linter! label Oct 9, 2021
courses/free-courses-fa_IR.md Outdated Show resolved Hide resolved
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 9, 2021
@eshellman eshellman merged commit 427846c into EbookFoundation:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants