Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Normalize localized filename format across all files #5560

Merged
merged 4 commits into from Sep 27, 2021

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Sep 27, 2021

What does this PR do?

Improve repo

For resources

Description

This handles something about file names and localization.

I see some files with a mixed nomenclature (locale code vs. language code). E.g.:

  • HOWTO.pt_BR.md (with dot/underscore) ❌
  • CONTRIBUTING-fa_IR.md (with dash/underscore) ✔️
  • CONTRIBUTING-zh-TW.md' (with dash/dash) ❌

Some ✔️ repo listing files: free-programming-books-fa_IR.md, free-programming-books-pt_BR.md. Then, the 99% follows the regex name(-locale)?.md where locale is in underscore format language_COUNTRY.

Then, CONTRIBUTING-zh-TW.md, HOWTO-zh-TW.md and HOWTO.pt_BR.md are renamed preserving commit history.

Why is this valuable (or not)?

This finishes normalizing the localized file names according to all the others in the project. Localization was introduced at:

Also I think it helps in some manner to improve #4579

Checklist:

Followup

  • Check the output of Travis-CI for linter errors!

/labelthis: breaking changes

@davorpa davorpa marked this pull request as ready for review September 27, 2021 14:27
@davorpa davorpa changed the title fix: Normalize localized filename format across all files fix(docs): Normalize localized filename format across all files Sep 27, 2021
@eshellman
Copy link
Collaborator

conflicts already!

@davorpa
Copy link
Member Author

davorpa commented Sep 27, 2021

conflicts already!

Due to touch same line in my other #5556. Resolved preserving HOWTO-fr.md 😉

@eshellman
Copy link
Collaborator

maybe I shouldn't have accepted #5561

Solving upstream rename conflict HOWTO.pt_BR.md > HOWTO-pt_BR.md, with also changes in this branch
@davorpa
Copy link
Member Author

davorpa commented Sep 27, 2021

maybe I shouldn't have accepted #5561

Solved rename conflict HOWTO.pt_BR.md > HOWTO-pt_BR.md, with also changes in file made in #5561

@eshellman eshellman merged commit b19f049 into EbookFoundation:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants