Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #4965

Closed
wants to merge 1 commit into from
Closed

Fix typo #4965

wants to merge 1 commit into from

Conversation

Sea-n
Copy link

@Sea-n Sea-n commented Oct 31, 2020

Hacktoberfest notes:

  • due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
  • please read our contributing guidelines
  • be sure to check the output of Travis-CI for linter errors
  • if this is your first open source contribution, make sure it's not your last!

What does this PR do?

Improve Repo

For resources

Description

Use "GitHub" instead of "Github"
Use "YouTube" instead of "Youtube"

Why is this valuable (or not)?

Improve readability

How do we know it's really free?

馃悎

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

* [Intoduction to Git and Github - Tutorial](http://cse.unl.edu/~cbourke/gitTutorial.pdf) - Dr. Chris Bourke (PDF)
* [How to Collaborate on GitHub](https://github.com/eonist/How-to-collaborate-on-github) - Andr茅 J
* [Intoduction to Git and GitHub](https://launchschool.com/books/git) - Launch School
* [Intoduction to Git and GitHub - Tutorial](http://cse.unl.edu/~cbourke/gitTutorial.pdf) - Dr. Chris Bourke (PDF)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be the title of this resource doesn't even contain GitHub, it's only "Introduction to Git", could we update it?

Suggested change
* [Intoduction to Git and GitHub - Tutorial](http://cse.unl.edu/~cbourke/gitTutorial.pdf) - Dr. Chris Bourke (PDF)
* [Intoduction to Git](http://cse.unl.edu/~cbourke/gitTutorial.pdf) - Dr. Chris Bourke (PDF)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And the mis-spelling "Introduction" also fixed.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even notice that! Nice catch! ^-^'

@eshellman eshellman closed this Oct 31, 2020
@eshellman eshellman reopened this Oct 31, 2020
@eshellman eshellman closed this Oct 31, 2020
@Sea-n
Copy link
Author

Sea-n commented Nov 1, 2020

Hello @eshellman, could I ask why you closed this PR?

CC @SethiPandi

@eshellman
Copy link
Collaborator

Because I didn't have time to check through the whole thing, and you didn't respect the source's capitalization on the one item I checked. Feel free to reopen, we won't be as grumpy later in November. In addition, PR's that change many pages cause many merge conflicts, which make it much more difficult to clean up our large backlog. I'd recommend separating this into 3 PRs, one addressing our capitalization of YouTube, one addressing GitHub, and another address source mismatch. Remember also that in capitalization may normalize differently depending on localization - probably not, but please check. Also, please read my comments in #4579: "We can elide 'YouTube' and 'Github" from listings. " Maybe I should have written "We should elide 'YouTube' and 'GitHub" from listings."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants