Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in #3672 #4700

Merged
merged 9 commits into from Oct 25, 2020
Merged

Fix broken links in #3672 #4700

merged 9 commits into from Oct 25, 2020

Conversation

charlottetan
Copy link
Contributor

Hacktoberfest notes:

  • due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
  • please read our contributing guidelines
  • be sure to check the output of Travis-CI for linter errors
  • if this is your first open source contribution, make sure it's not your last!

What does this PR do?

Improve Repo
Addresses #3672, went through all the links reported in the ticket, several were no longer in the file, some were false positives, some were truly broken and are fixed in this PR

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

@SethFalco
Copy link
Sponsor Member

SethFalco commented Oct 25, 2020

After you renamed "MySQL Tutorial..." To "MySQL 8.0...", it's position should've changed too since we keep lists in alphabetical order.

Could you just reorder the MySQL section please?

Edit: Alternatively you could rename it back as 8.0 does not appear to be a part of its name. The resource is simply called "MySQL Tutorial".

@charlottetan
Copy link
Contributor Author

Thanks @SethiPandi! Missed that!

@eshellman
Copy link
Collaborator

We really appreciate high quality PRs like this one.

@eshellman eshellman merged commit 6f44ca9 into EbookFoundation:master Oct 25, 2020
@charlottetan charlottetan deleted the patch-7 branch October 26, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants