Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable emoji on GitHub Pages #3013

Merged
merged 1 commit into from Oct 14, 2018
Merged

Enable emoji on GitHub Pages #3013

merged 1 commit into from Oct 14, 2018

Conversation

Blackgen
Copy link
Contributor

@Blackgen Blackgen commented Oct 13, 2018

What does this PR do?

This will enable emoji to be printed on the website. Currently only the keyword are printed.
Example:
馃摎 instead of :books:

This is related to #2479
More information about this topic can be found here:
https://help.github.com/articles/emoji-on-github-pages/

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate -> not needed
  • Lists are in alphabetical order -> not needed
  • Needed indications added (PDF, access notes, under construction)-> not needed

Live-Example:

A working example can be seen on my fork:
https://blackgen.github.io/free-programming-books/

Compare this to:
https://ebookfoundation.github.io/free-programming-books/

@eshellman
Copy link
Collaborator

That was an issue I had noticed! Thanks for the solution, and welcome to free-programming-books.

@eshellman eshellman merged commit 6056db8 into EbookFoundation:master Oct 14, 2018
JM-CR pushed a commit to JM-CR/free-programming-books that referenced this pull request Dec 24, 2018
JM-CR pushed a commit to JM-CR/free-programming-books that referenced this pull request Dec 24, 2018
ruimartinsptl pushed a commit to ruimartinsptl/free-programming-books that referenced this pull request May 22, 2019
ShamimWP pushed a commit to ShamimWP/free-programming-books that referenced this pull request Dec 3, 2019
DejanPerovic pushed a commit to DejanPerovic/free-programming-books that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants