Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sections and add books #2609

Closed
wants to merge 2 commits into from

Conversation

ahmadnourallah
Copy link

No description provided.

Copy link
Collaborator

@eshellman eshellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this set of contributions! Need to fix list order and remove or replace kutub.info links. See CONTRIBUTING.md for guidelines.

### Python

* [خطوة على طريق بايثون](http://www.linuxac.org/forum/memfiles/byteofpython_arabic.pdf) (PDF)
* [تعلم البرمجة مع باثون 3](https://www.kutub.info/library/book/18842)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kutub.info looks like a file-hosting site of the sort we don't permit. For example, the proper source for this book appears to be http://inforef.be/swi/download/apprendre_python3_arab.pdf It's a good practice to add the original author to help distinguish books with similar titles.

* [PHP](#php)
* [Programming in Scratch](#scratch)
* [Python](#python)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lists need to be in alphabetical order - see the travis ci output.

@@ -32,39 +39,55 @@
* [الإدارة المتقدمة لجنو/لينكس ](http://librebooks.org/gnu-linux-advanced-administration/)
* [دفتر مدير دبيان](http://librebooks.org/debian-handbook-arabic/)
* [دليل إدارة خواديم أوبنتو ](http://librebooks.org/ubuntu-server-guide-arabic/)
* [كتاب لينكس الشامل](https://www.kutub.info/library/book/596)
* [سطر اوامر لينكس](111000.net/systems/files/The_Linux_Command_Line-arabic-14.07.pdf) (PDF)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort order for lists is based on unicode- see issue #2503 where the issue is discussed.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Nov 24, 2017
@eshellman
Copy link
Collaborator

closed after 6 months for inactivity

@eshellman eshellman closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants