patch for possible SEH/Stack Buffer overflow (CVE-2023-33693) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestang98
changed the title
ernestang98
changed the title
ernestang98
changed the title
ernestang98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a SEH overflow vulnerability caused by using unsafe strcpy() function in xmlconfig.cpp file. A simple fix to this is to replace strcpy() with strncpy() and set a fix length for the URL field at 256.
This ensures that tsingsee/EasyPlayerPro all versions v3.2.19.0106 and v3.6.19.0823 is not vulnerable to a SEH overflow, mainly caused by the usage of unsafe strcpy() function in xmlconfig.cpp file LoadConfig() function, where strcpy() is used to copy over the user controlled URL field in EasyPlayerPro.xml. This leads to a Denial of Service (DoS) exploitation and may lead to arbitrary code execution (RCE) via SEH/stack buffer overflow.
POC:
https://www.youtube.com/watch?v=K27nGHa-hTE&feature=youtu.be&ab_channel=ErnestAng
https://www.youtube.com/watch?v=JkIhyO_z3VU&feature=youtu.be