Skip to content

Commit

Permalink
minor #6229 Update GitHub CI workflow config (javiereguiluz)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.x branch.

Discussion
----------

Update GitHub CI workflow config

Windows builds are failing on GitHub because of this error:

```
Run actions/cache@v4
Error: Input required and not supplied: path
```

I tried to debug this but I couldn't. I looked at other projects in the Symfony ecosystem but they use legacy v3 cache or not cache at all (e.g. https://github.com/doctrine/DoctrineBundle/blob/2.12.x/.github/workflows/continuous-integration.yml). So, let's try removing this cache and let's check if CI becomes much slower or not.

Commits
-------

7b37c4e Update GitHub CI workflow config
  • Loading branch information
javiereguiluz committed Mar 25, 2024
2 parents 1327179 + 7b37c4e commit df81f10
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/ci.yaml
Expand Up @@ -112,16 +112,6 @@ jobs:
extensions: mbstring, intl, pdo, pdo_sqlite, sqlite3
ini-values: date.timezone=UTC

- name: Get Composer cache directory
id: composer-cache
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT

- name: Mount PHP dependencies cache
uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-php-${{ matrix.php_version }}-symfony-${{ matrix.symfony_version }}-${{ matrix.stability }}

- name: symfony/flex is required to install the correct symfony version
if: ${{ matrix.symfony_version }}
run: |
Expand Down

0 comments on commit df81f10

Please sign in to comment.