chore(bazel): add MODULE.bazel files for bzlmod #1751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
bzlmod
branch
2 times, most recently
from
1d0db32
to
00878c4
Compare
|
I have rebased on upstream/latest and applied |
mmorel-35
commented
May 6, 2024
| "bazel-bin"], | ||
| "bazel-bin", | ||
| ], | ||
| linkopts = ["-lpthread"], |
There was a problem hiding this comment.
I added this for bazelbuild/bazel-central-registry#1940 to pass the presubmit validations
|
Looks good to me! Thank you @mmorel-35 |
|
Do you have any comments or suggestions, @Mizux |
Mizux
reviewed
May 7, 2024
Mizux
reviewed
May 7, 2024
Mizux
reviewed
May 7, 2024
mmorel-35
force-pushed
the
bzlmod
branch
2 times, most recently
from
18ff9fc
to
da56711
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provide a MODULE.bazel to be compatible with bzlmod
See Bzlmod Migration Guide for more information