Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the Meson build to fix portability issues and warnings #1737

Merged
merged 7 commits into from Apr 27, 2024
Merged

Updates to the Meson build to fix portability issues and warnings #1737

merged 7 commits into from Apr 27, 2024

Commits on Apr 26, 2024

  1. Meson build: avoid using add_languages('c') to fix a build warning 

    C is a required language it looks like, so just declare it normally
in the `project()` call.

The warning was:
```
meson.build:16: WARNING: add_languages is missing native:, assuming languages are wanted for both host and build.
```

Also clean up a stylistic issue and wrong comments for the threads
dependency - it is no longer required.
    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    85e67d6 View commit details
    Browse the repository at this point in the history

  2. Meson build: add note on issue on Windows with timestamp retrieval

    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    769b8d5 View commit details
    Browse the repository at this point in the history

  3. Meson build: improve clarity of what libraries are being linked 

    There was only one entry in `_linkto`, namely `highslib`. So the
extra variable was not needed, removing it makes it clearer what
is actually happening.
    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8290972 View commit details
    Browse the repository at this point in the history

  4. Meson build: ensure symbols from static library don't get reexported 

    This is both safer and reduces the binary size of the Python extension
modules that link against `libhighs.a`.
    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d4ee97a View commit details
    Browse the repository at this point in the history

  5. Meson build: bump version to 1.7.0

    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b094f96 View commit details
    Browse the repository at this point in the history

  6. Meson build: ensure compiler flags to silence warnings are used portably 

    The hardcoding may not work, and the flags were not used on any platform
other than Linux. This caused a lot of warnings when building on macOS.
    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3de2b8d View commit details
    Browse the repository at this point in the history

  7. Meson build: minor cleanup in highspy build config

    @rgommers
    rgommers committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1ab0520 View commit details
    Browse the repository at this point in the history