Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDDTableAggregateRows - override actual_range with min/max calculated on all chidren #150

Conversation

MarcoAlbaETT
Copy link
Contributor

Description

In EDDTableAggregateRows class override actual_range in tSourceAtts Attributes with min/max values calculated on all chidren.
This is to fix the problem about range for time,latitude,longitude and depth that is not the min/max of all the child but the range from the first child.

Fixes #145

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

override actual_range with min/max calculated on all chidren when making the variable
Copy link
Contributor

@ChrisJohnNOAA ChrisJohnNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running this through the full test set.

Are the data_min and data_max changes needed to fix the min/max values problem?

Copy link
Contributor

@ChrisJohnNOAA ChrisJohnNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests all passed.

@MarcoAlbaETT
Copy link
Contributor Author

I'm running this through the full test set.

Are the data_min and data_max changes needed to fix the min/max values problem?

Not really, but since I'm setting the actual_range and EDVTimeStamp is using that as first value, I think setting data_min and data_max is not needed.

@ChrisJohnNOAA ChrisJohnNOAA merged commit d17fd47 into ERDDAP:main May 14, 2024
@ChrisJohnNOAA
Copy link
Contributor

@MarcoAlbaETT I have a test that ensures the new code is working here: 532bb66

One thing to note, I'm using TS_SLEV_TAD_19 and TS_SLEV_TAD_1888 in the test which are different than the example in the issue.

@MarcoAlbaETT
Copy link
Contributor Author

@ChrisJohnNOAA thank you very much for the test and sorry for not doing it

@ChrisJohnNOAA
Copy link
Contributor

Thank you for doing the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"EDDTableAggregateRows" - Time, Latitude and Longitude min/max values are calculated from the first child only
2 participants