Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKEA_e2001_e2002 - Remove condition to check which button was released to trigger releas… #584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiridostal
Copy link

Proposed change

This PR removes a condition to check for the last value in the "input_text" to detect which button was pressed. This may not be an optimal solution and updating this PR with a new, working condition could be required. I did not figure out why the condition did not act as expected. Any contributions are welcome. This eventually closes #581

Checklist

  • [ x ] I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • [ x ] I properly tested proposed changes on my system and confirm that they are working as expected.
  • [ x ] I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hey @jiridostal, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@mkopec
Copy link

mkopec commented Feb 7, 2024

Thanks, this solved the issue for me where the release hook would not be triggered when releasing after long press. I'm using the STYRBAR remote via Zigbee2MQTT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IKEA LED2003G10 with IKEA E2001/E2002 Styrbar remote / Zigbee2MQTT
2 participants