Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #576] Philips Hue Dimmer v2 - Edit trigger_delta; make whitespacing optional. #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TTvanWillegen
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 馃帀
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Instead of obligatory whitespacing between the key-semicolon and value, make these optional. Same for whitespace between the two last_action parts.

Resolves #576. Instead of action taken as stated in issue (remove whitespace from regex), uses optional whitespace (\s*?)

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Instead of obligatory whitespacing between the key-semicolon and value, make these optional. Same for whitespace between the two last_action parts.
Copy link
Contributor

Hey @TTvanWillegen, thank you so much for your contribution! 馃殌

馃攧 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@TTvanWillegen TTvanWillegen changed the title Edit trigger_delta; make whitespacing optional. [#576] [Resolve #576] Philips Hue Dimmer v2 - Edit trigger_delta; make whitespacing optional. Nov 11, 2023
knirps99 added a commit to knirps99/awesome-ha-blueprints that referenced this pull request Jan 17, 2024
Including PR577 for double press of Philips hue dimmer remote v2

EPMatt#577
@nomike
Copy link

nomike commented Feb 3, 2024

I have come up with exactly the same solution and found this PR when I was about to submit mine.

I have tested it on my setup, it is safe could be merged IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Philips Hue Dimmer V2 - Double Press not recognized
2 participants