Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed regex to make double tap work again on HA 5.x #550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

comk22
Copy link

@comk22 comk22 commented May 25, 2023

After updating HA from 4.6 to 5.x double tap stopped working. Commiting this change as some did in other pull requests for the other Tradfri models. Double tap is working again with these changes.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 馃帀
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

Proposed change*

Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put closes #XXXX in this section to auto-close relevant issues.

Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.

Make sure to provide enough information so that your pull request can be reviewed.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

After updating HA from 4.6 to 5.x double tap stopped working. Commiting this change as some did in other pull requests for the other Tradri models. Double tap is working again with these changes.
@github-actions
Copy link
Contributor

Hey @comk22, thank you so much for your contribution! 馃殌

馃攧 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant