Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments and migrated the authentication to OAuth2 #32

Merged
merged 6 commits into from
Jun 9, 2024
Merged

Added comments and migrated the authentication to OAuth2 #32

merged 6 commits into from
Jun 9, 2024

Conversation

lasersPew
Copy link
Contributor

@lasersPew lasersPew commented Dec 26, 2023 •
edited

Fixes #26

@lasersPew lasersPew mentioned this pull request Dec 26, 2023
Closed
@lasersPew lasersPew changed the title Added comments and transitioned the __auth_handler to OAuth2 Added comments and migrated the authentication to OAuth2 Dec 26, 2023
@lasersPew
Copy link
Contributor Author

lasersPew commented Dec 26, 2023 •
edited

After some testing, the json part of the post method call breaks stuff. In the spec document, it says this:

This is an HTTP form. NOT a Json payload. If done correctly, it should have request Content-Type application/x-www-form-urlencoded

Do not merge yet!

Edit: Now you can merge it.

RatCornu
RatCornu reviewed Mar 30, 2024
View reviewed changes
mangadex/api.py Outdated Show resolved Hide resolved
@lasersPew @RatCornu
Added grant_type to auth payload
7bb8b6e 
Co-authored-by: Rat Cornu <98173832+RatCornu@users.noreply.github.com>
@EMACC99 EMACC99 merged commit 52ae7d5 into EMACC99:main Jun 9, 2024
1 check passed
@lasersPew lasersPew deleted the oauth branch June 10, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RatCornu RatCornu RatCornu left review comments

@EMACC99 EMACC99 EMACC99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use the login function
3 participants
@lasersPew @EMACC99 @RatCornu