Add particle boundary none #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
geometry: RZ
|
This is a good change since I've seen users be confused by what the lower boundary specification in RZ does. Looks like the RZ tests/examples just need to be updated still. |
roelof-groenewald
approved these changes
May 21, 2024
Haavaan
pushed a commit
to Haavaan/WarpX
that referenced
this pull request
Jun 5, 2024
* Add None particle boundary condition * Use None particle boundary in CI test langmuir/inputs_rz * Update BC for picmi input files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "None" as a particle boundary option, to correspond to the same option for the fields. This now must be used for the lower particle boundary in radius when it is specified when using RZ.