warpx.roundrobin_sfc: A runtime parameter to control distribution mapping #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
make_distromap
branch
2 times, most recently
from
99d9517
to
6f15ec5
Compare
…ping The default is false. If it's true, AMReX's RRSFS strategy will be used to override the default SFC strategy used by amrex::AmrCore. The motivation for this is that this might mitigate the load imbalance issue during initialization by avoiding putting neighboring boxes on the same process.
WeiqunZhang
force-pushed
the
make_distromap
branch
from
6f15ec5
to
275f45a
Compare
ax3l
added
the
component: load balancing
ax3l
reviewed
May 3, 2024
| @@ -1157,6 +1159,8 @@ WarpX::ReadParameters () | |||
| maxLevel() == 0 || !do_current_centering, | |||
| "Finite-order centering of currents is not implemented with mesh refinement" | |||
| ); | |||
|
|
|||
| pp_warpx.query("roundrobin_sfc", roundrobin_sfc); | |||
There was a problem hiding this comment.
This might need a user-facing entry in parameters.rst.
ax3l
reviewed
May 3, 2024
| @@ -219,6 +219,8 @@ bool WarpX::do_device_synchronize = true; | |||
| bool WarpX::do_device_synchronize = false; | |||
| #endif | |||
|
|
|||
| bool WarpX::roundrobin_sfc = false; | |||
There was a problem hiding this comment.
We need to add control for this from PICMI, too.
ax3l
added
the
component: initialization
|
Looks good. Would his affect the runtime, slowing the MPI communication since neighboring boxes will be far away from each other? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is false. If it's true, AMReX's RRSFC strategy will be used to override the default SFC strategy used by amrex::AmrCore. The motivation for this is that this might mitigate the load imbalance issue during initialization by avoiding putting neighboring boxes on the same process.