Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tune depth at which particles are removed, in the EB #4816

Draft
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Apr 2, 2024

Motivation:
In order to avoid artifacts whereby particles leave a spurious charge behind as they cross the EB (seen in plots of div(E)), it is sometimes desirable to remove particles only once they have moved deep enough inside the EB that their shape factor is entirely contained in the EB.

Here is an illustration of the issue occuring with div(E) (right picture): there is non-zero div(E) staying at the position where particles hit the EB
output

TODO:

  • Add automated test
  • Scale depth by the cell size ; update documentation accordingly. Indicate that the default is 0.
  • Update code that finds the particle intersection with the EB, so that WarpX only searched for the intersection at the timestep when particles cross the EB (not at later timesteps)

@RemiLehe RemiLehe marked this pull request as draft April 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant