[WIP] Tune depth at which particles are removed, in the EB #4816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In order to avoid artifacts whereby particles leave a spurious charge behind as they cross the EB (seen in plots of
div(E)
), it is sometimes desirable to remove particles only once they have moved deep enough inside the EB that their shape factor is entirely contained in the EB.Here is an illustration of the issue occuring with
div(E)
(right picture): there is non-zerodiv(E)
staying at the position where particles hit the EBTODO: