Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added update_parents flag and set default values for arity in selection operators #95

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

itaitzruia4
Copy link
Collaborator

For memory efficiency, Individual now has a field update_parents to only update parents optionally.

@achiyae achiyae requested review from achiyae and RonShef May 9, 2024 09:23
@itaitzruia4
Copy link
Collaborator Author

itaitzruia4 commented May 21, 2024

should be merged after #104

@achiyae
Copy link
Contributor

achiyae commented May 24, 2024

@itaitzruia4 I don't like this PR. By its name, it seems like it's only adding a flag, but there are 53 file changes!
Also, when I look at the changes, it's doing way more than adding a flag...

@itaitzruia4
Copy link
Collaborator Author

Re-opening to run examples workflow too

@itaitzruia4 itaitzruia4 reopened this May 29, 2024
@itaitzruia4
Copy link
Collaborator Author

@itaitzruia4 I don't like this PR. By its name, it seems like it's only adding a flag, but there are 53 file changes! Also, when I look at the changes, it's doing way more than adding a flag...

It's been a while since I wrote this code, but it looks like most of the changes are due to format fixes.
The actual changes are update_parents flag (which requires a change in many files as you mentioned), and setting a default value for arity field in Selection operators (number of individuals to be selected).

@itaitzruia4 itaitzruia4 changed the title added update_parents flag added update_parents flag and set default values for arity in selection operators May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants