termination_checker: added best_fitness_stagnation_termination_checker #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZvikaZ
force-pushed
the
termination_stagnation
branch
from
49f1f33
to
7ed474f
Compare
note that previous commit assumed that `best_individual` is best of *generation*. however, it's the best of the *run* (see PR EC-KitY#82). this commit fixes this mistake, and also checks for stagnation over all sub-populations
|
Note that the code has been changed since the review. Copying new commit's comment:
|
|
The minimal Python version is 3.6, so this function should be OK. |
|
@itaitzruia4 can we merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this uses
math.isclosewhich was introduced at Python 3.5.I assume that it's OK, but if not - it can be replaced with some other code.
Anyway, is there a definition of minimal supported Python version?