expose highlight color #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self._drawColor and self.colorDict have been adding as attributes to MolViewWidget The colorDict is a Dict["name": Tuple(R,G,B)] The "default" rdkit color is (1.0,0.5, 0.5) is also set here as defaul. Users can assign colorDict alternative colors And by setting the drawColor can change how the molecules are highlighted. The last highlighted atom is also highlight a little brighter (by a fifth to be precies)
|
It's duplicate functionality with the changes that are in the extended_features branch. I don't think the viewWidget should use the dictionary to set the colour, it should be more "dumb" and direct. I.e. if I want to make a viewWidget and set the colour, it should simply be doable by setting one setting, not a dictionary and a setting. The lookup in a dictionary of settings can be controlled from other classes, i.e. if one wants synchronized changes between highlight and last_highligt. |
|
Yes I can see the issue. I will just work with your branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self._drawColorandself.colorDicthave been added as attributes tomolViewWidgetThe
colorDictis aDict["name": Tuple(R,G,B)]The "default" rdkit color is
(1.0, 0.5, 0.5)is also set here as default.Users can assign
colorDictalternative colorsAnd by setting the drawColor can change how the molecules are highlighted.
The last selected atom is also highlighted a little brighter (by a fifth to be precise)