Skip to content

Commit

Permalink
Fixed pyside2 .13 problem, and now works with python3.11
Browse files Browse the repository at this point in the history
  • Loading branch information
Esben Jannik Bjerrum committed Apr 12, 2024
1 parent 3d3ec0e commit 5c229c2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ Sometimes they can be safely fixed with

`ruff check --fix` and even `ruff check --fix --unsafe-fixes` but otherwise they need to be inspected and mitigated.

## Deployment to PyPi

The github actions has been set to automatically deploy to pypi every time a new release is published.
The release will need a new tag created (incremented), otherwise PyPi will not accept the new package.

### Development Environment Setup

1. Follow the installation steps in the INSTALL section.
Expand Down
2 changes: 1 addition & 1 deletion rdeditor/rdEditor.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def exitFile(self):

# Function to show Diaglog box with provided Title and Message
def msgApp(self, title, msg):
userInfo = QMessageBox.question(self, title, msg, QMessageBox.Yes | QMessageBox.No)
userInfo = QMessageBox.question(self, title, msg, QMessageBox.Yes or QMessageBox.No)
if userInfo == QMessageBox.Yes:
return "Y"
if userInfo == QMessageBox.No:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
]
},
install_requires=["PySide2", "numpy", "rdkit", "pyqtdarktheme"],
python_requires=">=3.8, <3.11",
python_requires=">=3.8",
entry_points={
"console_scripts": [
"rdEditor = rdeditor.rdEditor:launch",
Expand Down

0 comments on commit 5c229c2

Please sign in to comment.