Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user adjustment of minimal informative protein threshold #65

Open
hoelzer opened this issue Jan 5, 2022 · 0 comments
Open

Allow user adjustment of minimal informative protein threshold #65

hoelzer opened this issue Jan 5, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@hoelzer
Copy link
Collaborator

hoelzer commented Jan 5, 2022

Currently, the minimum number of proteins with ViPhOG annotations at each taxonomic level, required for taxonomic assignment, is 2.

However, for certain use cases (see discussion in #64 ) it would be good if the user can change this, e.g. to "1" for short contigs or segmented viruses. However, this might lead to more FP hits.

The parameter is used in this script:

https://github.com/EBI-Metagenomics/emg-viral-pipeline/blob/master/bin/contig_taxonomic_assign.py#L103

which is called in this process:

https://github.com/EBI-Metagenomics/emg-viral-pipeline/blob/master/nextflow/modules/assign.nf#L15

@hoelzer hoelzer added the enhancement New feature or request label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant